Changeset 10806

Timestamp:

11/20/09 12:46:20 (3 years ago)

Author:

robert

Message:

From David Callu, "I have a Segfault with xine plugin, when I load a video, then delete the XineStreamImage?,
then reload a video and finally delete the second XineStreamImage?.

In src/osgPlugins/xine/video_out_rgb.c, many code is ASM code, and 'clear()' function is one of them.
If OSG is compiled without the flag COMPILE_ASSEMBLY (default behaviours) the clear() function is an empty
function and allocated memory is never initialized to 0. So a structure which contain pointer haven't its pointer set to NULL.
And when we need to delete this pointer, all go bad.

I join the fixed file."

Files:

• OpenSceneGraph/trunk/src/osgPlugins/xine/video_out_rgb.c (modified) (1 diff)

OpenSceneGraph/trunk/src/osgPlugins/xine/video_out_rgb.c

@@ -101 +101 @@
                 : "r" (size >> 2), "r" (size & 3), "0" (dest)
                 : "eax", "ecx");
+#else
+        memset(dest, 0, size);
 #endif
 }