Show
Ignore:
Timestamp:
01/23/15 18:15:20 (3 days ago)
Author:
robert
Message:

From Javier Taibo,
"I have found a "bug" in the new audio decoding code (actually I think the bug is in ffmpeg, but anyway it should be wise to protect the OSG plug-in about it). I am attaching a security check in FFmpegDecoderAudio.cpp.

If anybody is curious about the problem, it happens sometimes when decoding an AAC audio stream. It eventually includes a PCE block inside the AAC audio frame and then ffmpeg audio decoding function signals a "new_frame" with 1024 samples, but a null pointer instead of the audio data. It can be easily detected because in these cases number of channels is 0. Maybe this is the intended behaviour for ffmpeg, but I find it quite weird.
"

" It seems that libav does not have a channels attribute in AVFrame structure. This new version should do."

Files:
1 modified

Legend:

Unmodified
Added
Removed
  • OpenSceneGraph/trunk/src/osgQt/QGraphicsViewAdapter.cpp

    r13482 r14044  
    9292#endif 
    9393 
    94     _width = _graphicsScene->width(); 
    95     _height = _graphicsScene->height(); 
     94    _width = static_cast<int>(_graphicsScene->width()); 
     95    _height = static_cast<int>(_graphicsScene->height()); 
    9696 
    9797    _qimages[0] = QImage(QSize(_width, _height), s_imageFormat);