Changeset 9549

Timestamp:

01/26/09 16:16:24 (4 years ago)

Author:

robert

Message:

Fixed effective leak in Program::PerContextProgram? caused by previously osg::State keeping a set of std::ref_ptr<Program::PerContextProgram?> without ever pruning this list.
The fix was to convert the osg::State to use C pointers for the set of applied PerContexProgram? objects, and use the osg::Oberver mechanism to avoid dangling pointers for being maintained in osg::State.

Location:

OpenSceneGraph/trunk

Files:

• include/osg/Referenced (modified) (3 diffs)
• include/osg/State (modified) (5 diffs)
• src/osg/Referenced.cpp (modified) (2 diffs)
• src/osg/State.cpp (modified) (1 diff)
• src/osgWrappers/osg/State.cpp (modified) (2 diffs)

OpenSceneGraph/trunk/include/osg/Referenced

@@ -90 +90 @@
 
         /** Add a Observer that is observing this object, notify the Observer when this object gets deleted.*/
-        void addObserver(Observer* observer);
+        void addObserver(Observer* observer) const;
 
         /** Add a Observer that is observing this object, notify the Observer when this object gets deleted.*/
-        void removeObserver(Observer* observer);
+        void removeObserver(Observer* observer) const;
 
     public:
@@ -122 +122 @@
         struct ObserverSetData;
 
-        OpenThreads::AtomicPtr _observerSetDataPtr;
+        mutable OpenThreads::AtomicPtr _observerSetDataPtr;
 
         mutable OpenThreads::Atomic     _refCount;
@@ -131 +131 @@
         mutable int                     _refCount;
         
-        void*                           _observers;
+        mutable void*                   _observers;
 #endif
 };

OpenSceneGraph/trunk/include/osg/State

@@ -20 +20 @@
 #include <osg/Uniform>
 #include <osg/BufferObject>
+#include <osg/observer_ptr>
 
 #include <osg/FrameStamp>
@@ -85 +86 @@
   *   \c captureCurrentState() and \c getModelViewMatrix()).
   */
-class OSG_EXPORT State : public Referenced
+class OSG_EXPORT State : public Referenced, public Observer
 {
     public :
@@ -961 +962 @@
 
 
-        void setLastAppliedProgramObject(const Program::PerContextProgram* program) { if (_lastAppliedProgramObject!=program) { _lastAppliedProgramObject = program; if (program) _appliedProgramObjectSet.insert(program); } }
-        const Program::PerContextProgram* getLastAppliedProgramObject() const { return _lastAppliedProgramObject; }
+        inline void setLastAppliedProgramObject(const Program::PerContextProgram* program)
+        {
+            if (_lastAppliedProgramObject!=program)
+            {
+                _lastAppliedProgramObject = program; 
+                if (program && _appliedProgramObjectSet.count(program)==0)
+                {
+                    _appliedProgramObjectSet.insert(program); 
+                    program->addObserver(this);
+                }
+            }
+        }
+        inline const Program::PerContextProgram* getLastAppliedProgramObject() const { return _lastAppliedProgramObject; }
 
         inline GLint getUniformLocation( const std::string& name ) const { return _lastAppliedProgramObject ? _lastAppliedProgramObject->getUniformLocation(name) : -1; }
@@ -1065 +1077 @@
         void initializeExtensionProcs();
 
+        virtual void objectDeleted(void* object);
+
     protected:
 
@@ -1207 +1221 @@
         typedef std::vector<ref_ptr<const Matrix> >                     MatrixStack;
         
-        typedef std::set<osg::ref_ptr<const Program::PerContextProgram> > AppliedProgramObjectSet;
+        typedef std::set<const Program::PerContextProgram* >            AppliedProgramObjectSet;
 
         ModeMap                                                         _modeMap;

OpenSceneGraph/trunk/src/osg/Referenced.cpp

@@ -310 +310 @@
 }
 
-void Referenced::addObserver(Observer* observer)
+void Referenced::addObserver(Observer* observer) const
 {
 #if defined(_OSG_REFERENCED_USE_ATOMIC_OPERATIONS)
@@ -338 +338 @@
 }
 
-void Referenced::removeObserver(Observer* observer)
+void Referenced::removeObserver(Observer* observer) const
 {
 #if defined(_OSG_REFERENCED_USE_ATOMIC_OPERATIONS)

OpenSceneGraph/trunk/src/osg/State.cpp

@@ -91 +91 @@
 State::~State()
 {
+    for(AppliedProgramObjectSet::iterator itr = _appliedProgramObjectSet.begin();
+        itr != _appliedProgramObjectSet.end();
+        ++itr)
+    {
+        (*itr)->removeObserver(this);
+    }
+}
+
+void State::objectDeleted(void* object)
+{
+    const Program::PerContextProgram* ppcp = reinterpret_cast<const Program::PerContextProgram*>(object);
+    AppliedProgramObjectSet::iterator itr = _appliedProgramObjectSet.find(ppcp);
+    if (itr != _appliedProgramObjectSet.end()) 
+    {
+        osg::notify(osg::NOTICE)<<"Removing _appliedProgramObjectSet entry "<<ppcp<<std::endl;
+        _appliedProgramObjectSet.erase(itr);
+    }
 }
 

OpenSceneGraph/trunk/src/osgWrappers/osg/State.cpp

@@ -44 +44 @@
         I_DeclaringFile("osg/State");
         I_BaseType(osg::Referenced);
+        I_BaseType(osg::Observer);
         I_Constructor0(____State,
                        "",
@@ -716 +717 @@
                   __void__initializeExtensionProcs,
                   "Initialize extension used by osg:State. ",
+                  "");
+        I_Method1(void, objectDeleted, IN, void *, object,
+                  Properties::VIRTUAL,
+                  __void__objectDeleted__void_P1,
+                  "",
                   "");